Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test Permissions Page ... and Connections Page... #24607

Merged
merged 1 commit into from
May 20, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented May 20, 2024

Description

This PR fixes the following flaky tests:

  • Permissions Page should redirect users to connections page when users click on connected permission
  • Connections page should disconnect when click on Disconnect button in connections page

After this PR is merged, for fixing this tests we use the same approach, utilizing the new method for waiting for the notification to disappear after accepting it

async clickElementAndWaitToDisappear(rawLocator) {
    const element = await this.findClickableElement(rawLocator);
    await element.click();
    await element.waitForElementState('hidden');
  }

Open in GitHub Codespaces

Related issues

Fixes: #24597

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Artifacts from ci

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added team-extension-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) flaky tests labels May 20, 2024
@seaona seaona changed the base branch from develop to flaky-fix-dapp-viewed May 20, 2024 10:02
@seaona seaona marked this pull request as ready for review May 20, 2024 10:02
@seaona seaona requested a review from a team as a code owner May 20, 2024 10:02
@seaona seaona merged commit 27477cb into flaky-fix-dapp-viewed May 20, 2024
60 of 72 checks passed
@seaona seaona deleted the flaky-fix-connections-permissions branch May 20, 2024 10:03
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Flaky Test: Multiple tests failing with ElementClickInterceptedError on dapp interaction
1 participant