Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage folder sometimes doesn't need Kamal configuration in Rails 8.0.0.alpha #51836

Closed
jeromedalbert opened this issue May 15, 2024 · 1 comment · Fixed by #51838
Closed

Comments

@jeromedalbert
Copy link
Contributor

jeromedalbert commented May 15, 2024

Steps to reproduce

rails new myapp --main --skip-active-storage -d postgresql
cat config/deploy.yml

Expected behavior

config/deploy.yml should not configure a persistent storage volume.

Actual behavior

config/deploy.yml is configuring a persistent storage volume in this section:

# Use a persistent storage volume for sqlite database files and local Active Storage files.
# Recommended to change this to a mounted volume path that is backed up off server.
volumes:
  - "myapp_storage:/rails/storage"

System configuration

Rails version: 8.0.0.alpha

Ruby version: 3.3.1

Comments

According to the comment mentioned above in config/deploy.yml, a persistent storage volume seems to be needed only for sqlite and local Active Storage. If using a different database and the --skip-active-storage option, it doesn't seem needed.

Related: #51835
Potential fix: #51838

@yahonda
Copy link
Member

yahonda commented May 16, 2024

Would you add a test to make sure this option works as expected? I think some tests at https://github.com/rails/rails/blob/main/railties/test/generators/app_generator_test.rb are helpful as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants