Pass options to clone
instead of get
in applyVirtuals.
#14606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug introduced in v8.3.3 by #14543 caused
toJSON
to not be executed for virtual sub documents. The issue is caused by theoptions
being incorrectly passed into theget
function instead of theclone
function.Examples
I don't have an easy examples sorry, but I think the fix should be fairly evident. The intentions of #14543 was to pass
noDottedPath: true
to theget
function but it mistakenly included the clone options which should have been passed toclone
instead, as on line 4139 below it.