-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[METABRIDGE-843] chore: disable blocked tokens #24591
Conversation
296ff78
to
91647ce
Compare
You could update the |
f4d1d7f
to
1573b19
Compare
}; | ||
|
||
// A component that lets the user pick from a list of assets. | ||
export function AssetPicker({ | ||
asset, | ||
onAssetChange, | ||
sendingAsset, | ||
isDisabled = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we outright disable it? The current functionality shows the "send" option for both when "disabled"
1573b19
to
4c4b6a0
Compare
4c4b6a0
to
57d9a5f
Compare
Still needs a tooltip for disabled dest |
Description
Changes
Related issues
Fixes: N/A
Manual testing steps
Go to send page, chainId=1
ETH -> BNB should not be possible
BNB -> BNB should be possible
BNB -> ETH should not be possible
BNB -> USDC should not be possible
BNB -> TKN should not be possible
Switch to a chain that's not supported by swaps
There should be no errors/crashes when attempting to do a simple send flow
Console/Network tab should have no errors regarding the blockedTokens api call
Screenshots/Recordings
Blocked dest tokens disabled:
Screen.Recording.2024-05-17.at.6.00.15.PM.mov
Disable swap+send when src token is blocked:
Pre-merge author checklist
Pre-merge reviewer checklist