Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added helper text, learn-more and doc-link #5024

Merged
merged 8 commits into from
May 22, 2024
Merged

feat: added helper text, learn-more and doc-link #5024

merged 8 commits into from
May 22, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented May 17, 2024 •
edited

Summary

Related Issues / PR's

Screenshots

Screenshot 2024-05-17 at 4 09 39 PM Screenshot 2024-05-17 at 4 09 44 PM Screenshot 2024-05-20 at 10 34 37 PM Screenshot 2024-05-20 at 10 34 43 PM Screenshot 2024-05-20 at 11 49 39 PM image image Screenshot 2024-05-21 at 7 05 55 PM Screenshot 2024-05-21 at 7 13 04 PM image

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label May 17, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as draft May 20, 2024 06:12
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review May 20, 2024 20:37
vikrantgupta25
vikrantgupta25 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need Learn More here with here being the link? or Learn More being the link itself ?

@makeavish
Copy link
Member

we need Learn More here with here being the link? or Learn More being the link itself ?

We just need Learn More being the link itself

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7
Copy link
Contributor Author

we need Learn More here with here being the link? or Learn More being the link itself ?

We just need Learn More being the link itself

please check this -
image

its seems better to me - @Vikrant2520 @makeavish

@vikrantgupta25
Copy link
Collaborator

we need Learn More here with here being the link? or Learn More being the link itself ?

We just need Learn More being the link itself

please check this - image

its seems better to me - @Vikrant2520 @makeavish

the here still seems redundant. we can just highlight the module name itself

@vikrantgupta25
Copy link
Collaborator

also build is failing

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25
Copy link
Collaborator

image `this will persist across tab change here` ? what does this mean ?

@vikrantgupta25
Copy link
Collaborator

image

Can we have better grammar here ? Add new formula Learn more sounds very forceful, could be made a little polite like
Add new formula Looking for some more details ? Click here

@YounixM
Copy link
Collaborator

YounixM commented May 22, 2024

@SagarRajput-7: You can pick up the text changes later. Merging for now

@YounixM YounixM merged commit 4887a1d into develop May 22, 2024
11 of 12 checks passed
@YounixM YounixM deleted the learn-more-link branch May 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikrantgupta25 vikrantgupta25 vikrantgupta25 left review comments

@YounixM YounixM YounixM approved these changes

@makeavish makeavish makeavish approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SagarRajput-7 @makeavish @vikrantgupta25 @YounixM