feat(comment): commentstring hook for more control #28852
Conversation
Problem: it's difficult for users to customize the inbuilt commenting behavior (changing or extending) Solution: expose a hook that can override the selected commentstring, to allow for finer control Closes neovim#28830
|
The limitations were deliberate, for the sake of maintenance and documentation. There are enough plugins out there for people who want more control. (Not shutting this down, but there's a high bar to clear for adding functionality.) In particular, it was one of the requirements to not expose any API on this module. |
|
Ah, damn. That's fair; I'll wait for someone else to close if they choose to. Maybe someone will come up with a good alternative in the meantime |
| more accurate comments in JSX-family files (assuming the appropriate | ||
| |treesitter| parser has been installed): >lua | ||
|
|
||
| require('vim._comment').cs_hook = function(row, col) |
There was a problem hiding this comment.
"hook" is not a name used anywhere else in vim/nvim. Use existing names/conventions, to help discoverability.
This would typically be modeled as an "event" (autocmd) or a callback (on_foo).
|
#28830 (comment) gives a more likely alternative. Adding random hooks on top of the already numerous extension points is too much. 'commentstring' should be fixed instead. This PR doesn't explain why 'commentstring' isn't sufficient. |
wookayin
added
the
closed:wontfix
Problem: it's difficult for users to customize the inbuilt commenting behavior (changing or extending)
Solution: expose a hook that can override the selected commentstring, to allow for finer control
Closes #28830